Skip to content
This repository has been archived by the owner on Aug 29, 2021. It is now read-only.

Add Atom support #54

Open
MSpaceDev opened this issue Aug 17, 2018 · 4 comments
Open

Add Atom support #54

MSpaceDev opened this issue Aug 17, 2018 · 4 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@MSpaceDev
Copy link
Contributor

MSpaceDev commented Aug 17, 2018

Hey Levertion,

Firstly, been watching this project for a few months now. Looks like it's getting there. Excited for it.

So, I've pulled the master branch of the repo, created the project in Visual Studio, and compiled the package. npm run compile

I then moved the entire cloned folder into the packages section of Atom. I can see the package there, and it is working without errors, though I cannot select is as a language.

In Atom
image

Folder structure after compile
screenshot-12

Language Selection
image

@Levertion
Copy link
Owner

This is not an atom extension, it's a general language server for any editor. The fact that it loaded at all without errors shocks me and seems like an atom bug.

For it to work in atom, you would need a project similar to vscode-mcfunction, but for atom.

May I ask what is the mcfunction-langserver folder is, because I don't think that's because of something I've made.

@MSpaceDev
Copy link
Contributor Author

MSpaceDev commented Aug 21, 2018

The mcfunction-langserver was created when I loaded up the NJS project in VS. It's empty.

So, that begs the question, how would I use the language server with Atom? The structure of that vscode-mcfunction looks similar to the compiled structure from your repo. Or shall I just wait till' full release?

@Levertion
Copy link
Owner

You would create an atom extension which used https://github.com/atom/atom-languageclient and relied upon https://atom.io/packages/atom-ide-ui, similarly to vscode-mcfunction.

@Levertion Levertion added help wanted Extra attention is needed question Further information is requested labels Aug 23, 2018
@Levertion Levertion changed the title In usable state for atom? Add Atom support Sep 3, 2018
@Levertion
Copy link
Owner

I've renamed this issue to track creating an Atom extension

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed question Further information is requested
Projects
Development

No branches or pull requests

2 participants