Skip to content
This repository has been archived by the owner on Aug 29, 2021. It is now read-only.

Settings handling #89

Open
Levertion opened this issue Nov 3, 2018 · 0 comments
Open

Settings handling #89

Levertion opened this issue Nov 3, 2018 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@Levertion
Copy link
Owner

The current handling of settings is not optimal - we currently use a global variable to store all settings. Because of this, I haven't added any features which could be disableable yet

Ideally, we should investigate passing settings through the call stack. This however creates issues of a parameter only being present to pass down into lower functions in case it is needed.

One idea is to attach settings to a StringReader, but that isn't the purpose of the reader.

@Levertion Levertion added the help wanted Extra attention is needed label Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

1 participant