Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of shifted ApplyMasksUDF #1530

Open
uellue opened this issue Oct 23, 2023 · 0 comments
Open

Improve performance of shifted ApplyMasksUDF #1530

uellue opened this issue Oct 23, 2023 · 0 comments
Labels
enhancement New feature or request UDFs Anything related to the user-defined functions interface
Milestone

Comments

@uellue
Copy link
Member

uellue commented Oct 23, 2023

At the moment the shift compensation in ApplyMasksUDF can be a lot slower than the uncompensated one. When testing with the Radial Fourier example notebook and sparse masks, it was a bout a factor 25 slower. Dense masks will lead to an out of memory error there.

With optimized kernels that apply shifts to index calculations instead of slicing data, better performance should be achievable. Perhaps only a factor 3 slower?

@uellue uellue added enhancement New feature or request UDFs Anything related to the user-defined functions interface labels Oct 23, 2023
@uellue uellue added this to the backlog milestone Oct 23, 2023
@uellue uellue mentioned this issue Oct 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UDFs Anything related to the user-defined functions interface
Projects
None yet
Development

No branches or pull requests

1 participant