Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BufferWrapper #1611

Open
sk1p opened this issue Mar 13, 2024 · 0 comments
Open

Refactor BufferWrapper #1611

sk1p opened this issue Mar 13, 2024 · 0 comments

Comments

@sk1p
Copy link
Member

sk1p commented Mar 13, 2024

Right now, BufferWrapper is mixing a few concerns. I think it would make sense to break it up a bit:

  • Buffer declaration: basically UDF.buffer
  • "Partition-shaped" result buffer: has a partition slice set, might have a roi etc.
  • "Dataset-shaped" result buffers: contains the result "for the whole dataset" (which might be partial results still, basically what comes out of merge)

On another axis, it might make sense to make another split on the kind axis, as there are often special cases for nav and maybe sig, compared to single. If we have a PartResultBuffer, and inheriting from that, a NavPartResultBuffer, this should clear things up a bit.

The reason would be to have more static guarantees and with that also a better IDE experience, and to make the code easier to understand and modify. It should also make the interfaces exposed to users easier to understand - right now, the user just gets a BufferWrapper, but I can imagine that from the docs alone it's not clear how that is used in all the different cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant