Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better custom tab experience #341

Open
pressRtowin opened this issue Mar 11, 2024 · 4 comments
Open

Better custom tab experience #341

pressRtowin opened this issue Mar 11, 2024 · 4 comments
Assignees
Milestone

Comments

@pressRtowin
Copy link
Contributor

Feature description

I always thought it was pretty bad from a UX point of view that from looking at the native browser picker, there's nothing that visually distinguishes whether or not the link you're about to open will do so in the full browser or in a custom tab. Two interfaces that look exactly the same shouldn't lead to two wildly different outcomes.

Maybe LinkSheet could address this by including some sort of (optional) indicator. Even better would be a way to override the behavior (as https://github.com/TrianguloY/UrlChecker does, but implemented in a way that fits the design language of LinkSheet).

@1fexd 1fexd added this to the 1.1.0 milestone Mar 12, 2024
@1fexd 1fexd changed the title Better custom tab experience feature(1.1.0): Better custom tab experience Mar 12, 2024
@1fexd 1fexd changed the title feature(1.1.0): Better custom tab experience Better custom tab experience Mar 12, 2024
@saalkom
Copy link

saalkom commented Apr 20, 2024

I think I have a similar issue, if not the same one. If we are actually talking about the same underlying problem, then I think this issue might be better classified as a bug report and not a feature request.

I have absolutely no idea how to open a URL in a custom tab using LinkSheet (if the option indeed exists). I'm not an Android app dev (or a dev of any kind) and I don't know Java or Kotlin, but the many references to customTab (etc.) in the code seem to indicate that the said functionality is available in this app, however, for the life of me, I just can't figure out how to make use of it. If this apparent functionality is exposed somewhere in LinkSheet′s settings, then I assume it would be found under the Browser settings category, but seemingly no combination of configuration options in either subcategory results in URLs being opened in custom tabs under any circumstances. (For that matter, it's also not clear what the difference even is between setting a preferred app for In-app link handling and setting the in-app browser mode — I think the entire Browser settings category could do with some contextual help, including examples of what Android′s default behaviour looks like from the user's perspective.)

I know my browser (Edge) supports custom tabs, as I'm able to open any arbitrary URL in a custom tab in Edge using UrlChecker. If I've understood the OP correctly and LinkSheet even currently offers a custom tab experience at all, then it's just not at all evident how to access it.

@pressRtowin
Copy link
Contributor Author

Even better would be a way to override the behavior

@1fexd
Copy link
Collaborator

1fexd commented Apr 20, 2024

I think I have a similar issue, if not the same one. If we are actually talking about the same underlying problem, then I think this issue might be better classified as a bug report and not a feature request.

I have absolutely no idea how to open a URL in a custom tab using LinkSheet (if the option indeed exists). I'm not an Android app dev (or a dev of any kind) and I don't know Java or Kotlin, but the many references to customTab (etc.) in the code seem to indicate that the said functionality is available in this app, however, for the life of me, I just can't figure out how to make use of it. If this apparent functionality is exposed somewhere in LinkSheet′s settings, then I assume it would be found under the Browser settings category, but seemingly no combination of configuration options in either subcategory results in URLs being opened in custom tabs under any circumstances. (For that matter, it's also not clear what the difference even is between setting a preferred app for In-app link handling and setting the in-app browser mode — I think the entire Browser settings category could do with some contextual help, including examples of what Android′s default behaviour looks like from the user's perspective.)

I know my browser (Edge) supports custom tabs, as I'm able to open any arbitrary URL in a custom tab in Edge using UrlChecker. If I've understood the OP correctly and LinkSheet even currently offers a custom tab experience at all, then it's just not at all evident how to access it.

LinkSheet does not support opening links in custom tabs; It only pretends to support them so apps which don't allow disabling their (custom-tabs based) in-app browser think LinkSheet can provide this functionality, which LinkSheet then uses to act based on your In-App browser mode settings (e.g. disabling the in-app browser for any app by pretending to provide a custom tab, then just opening the link in an external browser regardless).

@saalkom
Copy link

saalkom commented Apr 21, 2024

I suppose I misread the original feature request.

And thank you, @1fexd , that helps me wrap my head around all this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants