Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Request dependency #170

Open
marcelomachado opened this issue Nov 4, 2022 · 3 comments
Open

Replace Request dependency #170

marcelomachado opened this issue Nov 4, 2022 · 3 comments
Labels
enhancement

Comments

@marcelomachado
Copy link
Contributor

Since request has been deprecated, see request/request#3142 wouldn't it be interesting to replace it to another library such as axios?
@rubensworks
Copy link
Member

Yes, we definitely need to replace it! :-)
I've had good experiences with node-fetch in other projects, so I can recommend that one (especially since fetch support is native in Node 18).

@marcelomachado
Copy link
Contributor Author

What do you think about doing this little by little? For example, in the datasource I am creating I have already added this dependency: marcelomachado@d29c332

@rubensworks
Copy link
Member

Sure, that's fine by me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rubensworks @marcelomachado