Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occur from retest GitHub Actions #405

Open
LinuxSuRen opened this issue Apr 26, 2024 · 14 comments
Open

Error occur from retest GitHub Actions #405

LinuxSuRen opened this issue Apr 26, 2024 · 14 comments
Labels
bug Something isn't working

Comments

@LinuxSuRen
Copy link
Owner

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: api-testing should not crash, the expected value isn't
returned, etc.

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like api-testing version, os version and so on.

Logs:

Include the access logs and the api-testing logs.

image

@LinuxSuRen LinuxSuRen added the bug Something isn't working label Apr 26, 2024
@LinuxSuRen
Copy link
Owner Author

hi @yuluo-yx Please help to take a look at this error.

@LinuxSuRen
Copy link
Owner Author

It looks like every comment will trigger it.

image

@LinuxSuRen
Copy link
Owner Author

I just reverted it. We can add it once you fixed it.

@Ink-33
Copy link
Contributor

Ink-33 commented Apr 26, 2024

Maybe the version should be lowercase yuluo-yx/gh-retest@v1.0.0-RC1

- uses: yuluo-yx/gh-retest@V1.0.0-RC1

@yuluo-yx
Copy link
Contributor

sorry, is my question, It version is v1.0.0-RC1, I write was V1.0.0-RC1 😢😢

@LinuxSuRen
Copy link
Owner Author

But why it is triggered no matter what comment is created. I think we need to add a filter. It can be triggered only the specific comment created.

@yuluo-yx
Copy link
Contributor

But why it is triggered no matter what comment is created. I think we need to add a filter. It can be triggered only the specific comment created.

The current logic is to get the comment content and run the failed task if it is /retest.

I'll implement his. 🤔

@LinuxSuRen
Copy link
Owner Author

I'm not sure if GitHub Actions support that kind of filter.

@yuluo-yx
Copy link
Contributor

I'm not sure if GitHub Actions support that kind of filter.

Let me see the documentation and study it

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Apr 26, 2024

@LinuxSuRen I study envoy repo command.yml. I've found that I have to run a workflows anyway, and github doesn't have a hook for that.

For more information you can refer to this comment, it's not /retest but judging from the action logs, it's still executing it, but not the retest action

action:
https://github.com/envoyproxy/envoy/actions/runs/8845882918/job/24290669995
comment:
envoyproxy/envoy#33818 (comment)

@LinuxSuRen
Copy link
Owner Author

I'm afraid too many triggers will burn out the GitHub Actions minutes. See also the official document.

2,000 minutes per month

@yuluo-yx
Copy link
Contributor

I'm afraid too many triggers will burn out the GitHub Actions minutes. See also the official document.

2,000 minutes per month

got it, It's a factor that really needs to be taken into account 🤔

@LinuxSuRen
Copy link
Owner Author

By the way, you can make it be a webook server. And I know a free service that can deploy it. See https://zeabur.com/pricing

@yuluo-yx
Copy link
Contributor

By the way, you can make it be a webook server. And I know a free service that can deploy it. See https://zeabur.com/pricing

tks, let me study

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants