Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider configuring output for logging (mainly in validation package) #126

Open
ftomassetti opened this issue Feb 9, 2024 · 4 comments

Comments

@ftomassetti
Copy link
Contributor

In particular I found this instance:

@joswarmer
Copy link
Contributor

You are right, will remove all console.* and put make them configurable.

@ftomassetti
Copy link
Contributor Author

I am working on PR around that for the lionweb-repository

@ftomassetti
Copy link
Contributor Author

The PR for the lionweb-repository that I was talking about is this one: LionWeb-io/lionweb-repository#27

@dslmeinte
Copy link
Contributor

I think this issue is still (somewhat) relevant. There are 19 occurrences of the use of console.log in the @lionweb/validation package, as well as 15 commented-out ones.

@dslmeinte dslmeinte changed the title Consider removing or control by flag extra output Consider configuring output for logging (mainly in validation package) May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants