Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: use new auth #117

Merged
merged 4 commits into from
Aug 13, 2022
Merged

BREAKING CHANGE: use new auth #117

merged 4 commits into from
Aug 13, 2022

Conversation

LironEr
Copy link
Owner

@LironEr LironEr commented Aug 6, 2022

related: #103

This PR introduces an automatic way to create a project if your repo is hosted on GitHub and using GitHub Actions.

Currently, if BundleMon GitHub app is installed for your repo, you can create GitHub outputs by using project API key, which due to recent finds, may be exploited.

After the release of BundleMon CLI v2, v1 will be deprecated and will stop working in a few months.

Create GitHub outputs by using one of the options:

  1. Providing GitHub access token.
  2. Have the BundleMon GitHub app installed and run BundleMon CLI in GitHub actions.

@LironEr LironEr changed the base branch from master to next August 6, 2022 08:11
@bundlemon-next
Copy link

bundlemon-next bot commented Aug 6, 2022

BundleMon

Files added (12)
Status Path Size Limits
JS files
321.(hash).js
+389.85KB -
main.(hash).js
+277.29KB -
JS files
85.(hash).js
+79.54KB -
JS files
474.(hash).js
+69.05KB -
JS files
635.(hash).js
+64.98KB -
JS files
677.(hash).js
+51.68KB -
JS files
ReportsPage.(hash).js
+17.02KB -
JS files
ReportPage.(hash).js
+16.6KB -
JS files
708.(hash).js
+11.44KB -
JS files
CreateProjectPage.(hash).js
+11.39KB -
JS files
ReportsChart.(hash).js
+6.45KB -
index.html
+756B -

Total files change +996.02KB

Groups added (2)
Status Path Size Limits
JS files
**/*.js
+995.28KB -
Images
**/*.png
+370.53KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #117 (4f677c3) into next (6239024) will increase coverage by 0.28%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             next     #117      +/-   ##
==========================================
+ Coverage   57.10%   57.39%   +0.28%     
==========================================
  Files          59       59              
  Lines        1450     1495      +45     
  Branches      292      303      +11     
==========================================
+ Hits          828      858      +30     
- Misses        622      637      +15     
Impacted Files Coverage Δ
...ckages/bundlemon/src/main/report/generateReport.ts 100.00% <ø> (ø)
service/src/controllers/githubController.ts 14.54% <0.00%> (-0.27%) ⬇️
service/src/framework/github.ts 12.03% <0.00%> (ø)
...kages/bundlemon/src/main/outputs/outputs/github.ts 17.54% <15.38%> (-0.11%) ⬇️
packages/bundlemon/src/common/service.ts 16.66% <22.22%> (-0.58%) ⬇️
service/src/controllers/utils/auth.ts 91.11% <66.66%> (-4.35%) ⬇️
packages/bundlemon/src/main/utils/configUtils.ts 39.50% <79.16%> (+10.93%) ⬆️
service/src/controllers/projectsController.ts 90.32% <82.35%> (-9.68%) ⬇️
packages/bundlemon/src/common/consts.ts 100.00% <100.00%> (ø)
packages/bundlemon/src/main/initializer.ts 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LironEr
Copy link
Owner Author

LironEr commented Aug 13, 2022

@armanbilge please look at af3b8e0, as the "get or create project ID" endpoint changed.
I wanted to verify if a provider is authenticated before creating a project id to fail the CLI as early as possible and not to create projects that don't have permissions to create a commit record.

I didn't deploy this change to production, currently, it's in a test environment.

@armanbilge
Copy link

@LironEr thanks for the heads-up, much appreciated! I've made the changes in armanbilge/sbt-bundlemon#11 and verified them against your test environment. Seems to be working, so let me know when it's in production :)

@LironEr
Copy link
Owner Author

LironEr commented Aug 19, 2022

@armanbilge I deployed to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants