Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to post GitHub output only on failures #123

Closed
LironEr opened this issue Aug 19, 2022 · 3 comments
Closed

ability to post GitHub output only on failures #123

LironEr opened this issue Aug 19, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@LironEr
Copy link
Owner

LironEr commented Aug 19, 2022

It would also be great to have a way to report the output differently in case of "failures".
For example, the report as PR comment can be very noisy in a monorepo with multiple projects reporting as PR comments, but if we can set the PR comment to be only in case of "failure", that would already be a lot less noisy.

Originally posted by @tleunen in #115 (comment)

@LironEr LironEr added the enhancement New feature or request label Aug 19, 2022
@LironEr
Copy link
Owner Author

LironEr commented Aug 19, 2022

Each output will accept

"always" / "on-failure" / "off"

default:

"reportOutput": [
  [
    "github",
    {
      "checkRun": "off",
      "commitStatus": "always",
      "prComment": "always"
    }
  ]
]

@tleunen what do you think?

@tleunen
Copy link
Contributor

tleunen commented Aug 19, 2022

Exactly what I had in mind, and you kept true/false in your PR to be backward compatible so this is great.
Thank you!

@LironEr LironEr added this to the v2 milestone Aug 26, 2022
@LironEr LironEr closed this as completed in 232a152 Oct 8, 2022
@LironEr
Copy link
Owner Author

LironEr commented Oct 8, 2022

Feature available in bundlemon@2.0.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants