Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to post GitHub output only on failures #124

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

LironEr
Copy link
Owner

@LironEr LironEr commented Aug 19, 2022

resolves #123

]
```

Each option support one of: `true | false | "always" | "on-failure" | "off"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change backwards-compatibly 🙏

@bundlemon
Copy link

bundlemon bot commented Aug 19, 2022

BundleMon

Unchanged files (12)
Status Path Size Limits
JS files
321.(hash).js
390.6KB -
main.(hash).js
276.64KB -
JS files
85.(hash).js
79.51KB -
JS files
474.(hash).js
68.96KB -
JS files
635.(hash).js
64.91KB -
JS files
677.(hash).js
51.64KB -
JS files
ReportsPage.(hash).js
17.07KB -
JS files
ReportPage.(hash).js
16.59KB -
JS files
708.(hash).js
11.41KB -
JS files
CreateProjectPage.(hash).js
11.38KB -
JS files
ReportsChart.(hash).js
6.45KB -
index.html
756B -

No change in files bundle size

Unchanged groups (2)
Status Path Size Limits
JS files
**/*.js
995.14KB -
Images
**/*.png
370.53KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #124 (6bafbf5) into next (31a7118) will increase coverage by 0.68%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##             next     #124      +/-   ##
==========================================
+ Coverage   57.16%   57.84%   +0.68%     
==========================================
  Files          59       59              
  Lines        1508     1523      +15     
  Branches      316      322       +6     
==========================================
+ Hits          862      881      +19     
+ Misses        646      642       -4     
Impacted Files Coverage Δ
...kages/bundlemon/src/main/outputs/outputs/github.ts 31.08% <68.75%> (+14.13%) ⬆️
packages/bundlemon/src/common/logger.ts 78.12% <0.00%> (+18.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LironEr LironEr merged commit 232a152 into next Aug 20, 2022
@LironEr LironEr deleted the feat/conditional-post-github-output branch August 20, 2022 13:16
@LironEr LironEr added this to the v2 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants