Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): approve limit exceeded #133

Merged
merged 9 commits into from
Oct 6, 2022
Merged

feat(service): approve limit exceeded #133

merged 9 commits into from
Oct 6, 2022

Conversation

LironEr
Copy link
Owner

@LironEr LironEr commented Oct 2, 2022

Related #115

Login with GitHub and approve commit records (from the BundleMon website).

By approving the commit record the related GitHub outputs statuses will change to "success".

TODO

  • Disapprove
  • Change PR comment & check run content final status to success if approved, also add an indication that someone approved the commit
  • Need to add tests to GitHub functions

I will probably merge without the TODO list, and will open tasks for them

@LironEr LironEr added this to the v2 milestone Oct 2, 2022
@bundlemon
Copy link

bundlemon bot commented Oct 2, 2022

BundleMon

Unchanged files (11)
Status Path Size Limits
JS files
321.(hash).js
390.47KB -
main.(hash).js
322.5KB -
JS files
845.(hash).js
86.73KB -
JS files
635.(hash).js
64.9KB -
JS files
474.(hash).js
62.11KB -
JS files
672.(hash).js
29.63KB -
JS files
CreateProjectPage.(hash).js
13.8KB -
JS files
ReportPage.(hash).js
11.61KB -
JS files
ReportsPage.(hash).js
11.06KB -
JS files
ReportsChart.(hash).js
5.58KB -
index.html
756B -

No change in files bundle size

Unchanged groups (2)
Status Path Size Limits
JS files
**/*.js
998.39KB -
Images
**/*.png
370.53KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@LironEr LironEr marked this pull request as ready for review October 4, 2022 18:48
@LironEr LironEr changed the title [WIP] feat(service): approve limit exceeded feat(service): approve limit exceeded Oct 5, 2022
@LironEr LironEr closed this Oct 6, 2022
@LironEr LironEr reopened this Oct 6, 2022
@LironEr LironEr merged commit 387bfa1 into next Oct 6, 2022
@LironEr LironEr deleted the feat/service/approve branch October 6, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant