Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup React error boundaries to prevent one component breaking the whole app #643

Closed
faival opened this issue Mar 29, 2018 · 1 comment
Closed

Setup React error boundaries to prevent one component breaking the whole app #643

faival opened this issue Mar 29, 2018 · 1 comment
Assignees
@faival
Projects
Version 0.7.0 Sprint Board 30-04-18

Comments

@faival
Copy link
Contributor

faival commented Mar 29, 2018 •
edited

Expected Behaviour

  • An error in a component does not affect the whole application, (e.g. rest of components are usable and state is reseted)

Actual behaviour

  • An error triggered on one component can break the whole application

Steps to reproduce

Notes

  • investigate with medium till POC
  • then create hard followup for implementation

Related issues
@faival faival created this issue from a note in Sprint Board 03-04-18 (New issues) Mar 29, 2018
@faival faival self-assigned this Mar 29, 2018
@faival faival added the *medium label Mar 29, 2018
@faival faival added this to Issues in Version 0.5.0 via automation Mar 29, 2018
@faival faival changed the title Setup React error boundaries to prevent one component breaking the whole app - Pablo *medium Setup React error boundaries to prevent one component breaking the whole app Mar 29, 2018
@alepop
Copy link
Contributor

alepop commented Mar 29, 2018

@faival I hope it will help you https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html

@slaweet slaweet added this to New Issues in Sprint Board 09-04-18 via automation Apr 3, 2018
@slaweet slaweet removed this from New issues in Sprint Board 03-04-18 Apr 3, 2018
@slaweet slaweet added the chore label Apr 12, 2018
@slaweet slaweet removed this from Issues in Version 0.5.0 Apr 13, 2018
@slaweet slaweet added this to Issues in Version 0.6.0 via automation Apr 13, 2018
@slaweet slaweet removed this from New Issues in Sprint Board 09-04-18 Apr 16, 2018
@slaweet slaweet added this to New Issues in Sprint Board 16-04-18 via automation Apr 16, 2018
@slaweet slaweet moved this from New Issues to Previous Issues in Sprint Board 16-04-18 Apr 16, 2018
@slaweet slaweet added this to New Issues in Sprint Board 23-04-18 via automation Apr 23, 2018
@slaweet slaweet removed this from Previous Issues in Sprint Board 16-04-18 Apr 23, 2018
@faival faival mentioned this issue Apr 25, 2018
Merged
@slaweet slaweet removed this from Issues in Version 0.6.0 Apr 27, 2018
@slaweet slaweet added this to Issues in Version 0.7.0 via automation Apr 27, 2018
@slaweet slaweet added this to New Issues in Sprint Board 30-04-18 via automation May 3, 2018
@slaweet slaweet removed this from New Issues in Sprint Board 23-04-18 May 3, 2018
faival added a commit that referenced this issue May 11, 2018
@faival
Merge pull request #760 from LiskHQ/643-setup-react-error-boundaries
de7962e 
Setup React error boundaries to prevent one component breaking the whole app - Closes #643
@faival faival closed this as completed May 11, 2018
Sprint Board 30-04-18 automation moved this from New Issues to Closed Issues May 11, 2018
Version 0.7.0 automation moved this from Issues to Closed Issues May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faival faival

Labels
None yet
Projects
No open projects
Sprint Board 30-04-18
  
Closed Issues
Version 0.7.0
  
Closed Issues
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faival @alepop @slaweet