Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser field in package.json #3348

Closed
shuse2 opened this issue Nov 16, 2018 · 3 comments · Fixed by #6049
Closed

Add browser field in package.json #3348

shuse2 opened this issue Nov 16, 2018 · 3 comments · Fixed by #6049
Assignees
@nazarhussain
Labels
elements unplanned
Milestone
Sprint 34

Comments

@shuse2
Copy link
Member

shuse2 commented Nov 16, 2018

Description

Browser field should be re-introduced in the package.json

With the correct setup, browserify reads the browser field and it fails, but with --no-browser-field, --no-bf, it doesn't replace the node variable correct.

related: browserify/browserify#1826

Remarks

  • Check in browser
  • Check in Lisk-Hub
  • Check in Lisk-Mobile
@shuse2 shuse2 self-assigned this Nov 17, 2018
@shuse2
Copy link
Member Author

shuse2 commented Nov 19, 2018

browserify/browserify#1826

Tried this change, and it's working fine

@shuse2 shuse2 removed their assignment Nov 19, 2018
@shuse2 shuse2 transferred this issue from LiskArchive/lisk-elements Apr 15, 2019
@shuse2 shuse2 mentioned this issue Aug 27, 2019
Closed
@JesusTheHun
Copy link
Contributor

Is this issue status up to date ?

@shuse2
Copy link
Member Author

shuse2 commented Mar 10, 2020 •
edited

The referred PR in the browserify is not merged yet, so I asked the question there as well.
I tried the latest browserify release but it also doesn't work.

In the mean time, in which environment are you having the problem with? @JesusTheHun

@shuse2 shuse2 mentioned this issue Dec 11, 2020
Closed
@nazarhussain nazarhussain self-assigned this Dec 11, 2020
@shuse2 shuse2 added this to the Sprint 34 milestone Dec 15, 2020
@nazarhussain nazarhussain mentioned this issue Dec 15, 2020
Merged
@nazarhussain nazarhussain linked a pull request Dec 15, 2020 that will close this issue
Lisk Client for browser - Closes #4163,#3348 #6049
Merged
shuse2 added a commit that referenced this issue Dec 15, 2020
@shuse2
Merge pull request #6049 from LiskHQ/4163-browser-export
230a2d6 
Lisk Client for browser - Closes #4163,#3348
@shuse2 shuse2 closed this as completed Jan 5, 2021
@sridharmeganathan sridharmeganathan mentioned this issue Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nazarhussain nazarhussain

Labels
elements unplanned
Projects
None yet
Milestone
Sprint 34
Development

Successfully merging a pull request may close this issue.

Lisk Client for browser - Closes #4163,#3348 LiskHQ/lisk-sdk
4 participants
@JesusTheHun @nazarhussain @shuse2 @sridharmeganathan