Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Add support for Font-Awesome V6 #1424

Open
Lissy93 opened this issue Dec 31, 2023 · 0 comments
Open

[FEATURE_REQUEST] Add support for Font-Awesome V6 #1424

Lissy93 opened this issue Dec 31, 2023 · 0 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@Lissy93
Copy link
Owner

Lissy93 commented Dec 31, 2023

Is your feature request related to a problem? If so, please describe.

Currently only icons in FA V5 can be used. This is because the newer version of Font Awesome fetches and names icons differently. This ticket proposes adding support for the newer FA V6 icons, while keeping backwards compatibility.

Describe the solution you'd like

So currently FA icons are just pulled in dynamically like:

<i :class="`${icon} ${size}`" ></i>

I reckon using the webfont would be the best option. This can also be self-hosted, for full offline usage, or possible installed as a dependency (if it's not too large - I'll need to check).

Icons in V5 are named differently from those in V6, so thought will need to be given on how to prevent any breaking changes. If not possible, maybe this is going to be a job for Dashy V3 which is having several parts completely re-written, and therefore won't be backwards compatible anyway.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

Yes!

@Lissy93 Lissy93 added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

1 participant