Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Unify weather and weather forecast widgets #1475

Open
bogdanjsx opened this issue Feb 26, 2024 · 5 comments
Open

[FEATURE_REQUEST] Unify weather and weather forecast widgets #1475

bogdanjsx opened this issue Feb 26, 2024 · 5 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@bogdanjsx
Copy link

Is your feature request related to a problem? If so, please describe.

Hi! I started using the weather forecast widget and it behaves a bit strangely - see image.
image

I checked the response from the openweathermap API and it looks like for the forecast the increment is 3 hours, not 1 day. That's probably why the same day gets shown 5 times in my case.

Describe the solution you'd like

Openweathermap migrated to One Call API 3.0, which is also free for <1000 calls/day (more than enough for a regular user), so I think Dashy should, as well.

As an improvement, since the new API returns both current weather and forecast in multiple time period steps, in my opinion the best solution would be to have a single weather widget which can display any type of forecast(hourly/daily/none) based on config.
This also avoids a double call to the API if a user wants all of this info - right now the only option would be having both widgets.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

None

@bogdanjsx bogdanjsx added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Feb 26, 2024
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@bogdanjsx
Copy link
Author

Just checked the open issues and this is probably a duplicate of #1376.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 26, 2024
@Lissy93
Copy link
Owner

Lissy93 commented Feb 26, 2024

Hey @bogdanjsx.
Re the incorrect dates, yeah that's a dup of #1376 - But your insight (3 hour increments) is the cause, so thank you for finding that!

In terms of combining the weather + weather forecast widgets, there have been some other tickets relating to the weather widget, and the API and endpoints used. The solution to which is probably going to be re-writing the weather widgets, at which point I'll look into combining current + foretasted weather.

I'm going to find those other tickets and reference/link to your ticket, and then close this issue, just to reduce clutter.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 26, 2024
@CrazyWolf13
Copy link
Collaborator

Spent hours, till I finally found out it was the api's fault and time was 3 hour increment ->
#1376 (comment)
👍
@Lissy93
If you plan to fully rewrite it, then i'll probably not make any PR's to this.

@CrazyWolf13
Copy link
Collaborator

Also linking #903 to here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

4 participants