Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] CVE that should be fixed #67

Closed
lcotonea opened this issue Jun 26, 2021 · 2 comments
Closed

[FEATURE_REQUEST] CVE that should be fixed #67

lcotonea opened this issue Jun 26, 2021 · 2 comments
Assignees
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@lcotonea
Copy link

Hi,

After a security scan, two CVEs have been found on node modules:

  • CVE-2020-28469: This affects the package glob-parent before 5.1.2. The enclosure regex used to check for strings ending in enclosure containing path separator
  • CVE-2021-33502: The normalize-url package before 4.5.1, 5.x before 5.3.1, and 6.x before 6.0.1 for Node.js has a ReDoS (regular expression denial of service) issue because it has exponential performance for data: URLs.

These modules should be upgraded.

@lcotonea lcotonea added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Jun 26, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Jun 26, 2021

Hey, unfortunately these packages are used by other dev packages (mostly Vue CLI), which are already at the latest version. You need to raise the issue / submit a PR to them instead.

Here's the full dependency path to help you:

  • normalize-url is used by @vue/cli-service > cssnano > cssnano-preset-default > postcss-normalize-url > normalize-url which of course doesn't effect the production application
  • glob-parent is also used by @vue/cli-service > copy-webpack-plugin > glob-parent
  • css-what is used by @vue/cli-service > cssnano > cssnano-preset-default > postcss-svgo > svgo > css-select > css-what

You'll find the same results in most Vue projects at the moment, there are actually 6 critical vulnerabilities in Vue CLI. In Dashy specifically isn't actually effected by any of these vulnerabilities, as it's not using the effected packages in production, so is nothing to worry about.

I'm using Synk for vulnerability checking, you can find the current report here: https://snyk.io/test/github/Lissy93/dashy

@Lissy93 Lissy93 closed this as completed Jun 26, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Jun 26, 2021

Btw it looks like these issues are already raised, see below:

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

2 participants