Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symbol.dispose in JavaScript / TypeScript bindings #686

Closed
CryZe opened this issue Jun 16, 2023 · 1 comment
Closed

Use Symbol.dispose in JavaScript / TypeScript bindings #686

CryZe opened this issue Jun 16, 2023 · 1 comment
Labels
bindings This is about the bindings / binding generator. code quality Affects the quality of the code. enhancement An improvement for livesplit-core.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Jun 16, 2023

Apparently JavaScript / TypeScript are getting the same using keyword / dispose pattern as C#, which is exactly what we already manually emulate in our bindings: https://twitter.com/mattpocockuk/status/1669630994280849408
@CryZe CryZe added enhancement An improvement for livesplit-core. code quality Affects the quality of the code. bindings This is about the bindings / binding generator. labels Jun 16, 2023
@CryZe
Copy link
Collaborator Author

CryZe commented May 18, 2024

Resolved by #804

@CryZe CryZe closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bindings This is about the bindings / binding generator. code quality Affects the quality of the code. enhancement An improvement for livesplit-core.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CryZe