Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Settings #800

Open
CryZe opened this issue May 2, 2024 · 0 comments
Open

Refactor Settings #800

CryZe opened this issue May 2, 2024 · 0 comments
Labels
code quality Affects the quality of the code. enhancement An improvement for livesplit-core. needs further discussion It is unclear how to progress without making further decisions.

Comments

@CryZe
Copy link
Collaborator

CryZe commented May 2, 2024

At the moment the settings are entirely described through the enum variants and their values. However this has become quite annoying because we use different variants for the different kinds of combo boxes we have. It would be much better if we could just dynamically describe a combo box instead. This is not currently possible because the options would need to be part of the value, which means they would also be stored back when changing such a setting, which doesn't make any sense.

We should look into further improvements such as groups and tooltips while doing this refactoring.

@CryZe CryZe added enhancement An improvement for livesplit-core. needs further discussion It is unclear how to progress without making further decisions. code quality Affects the quality of the code. labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Affects the quality of the code. enhancement An improvement for livesplit-core. needs further discussion It is unclear how to progress without making further decisions.
Projects
None yet
Development

No branches or pull requests

1 participant