Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciliation for components defined in a workspace #1121

Open
linusha opened this issue Dec 4, 2023 · 1 comment
Open

Reconciliation for components defined in a workspace #1121

linusha opened this issue Dec 4, 2023 · 1 comment
Labels
✨ enhancement New feature or request

Comments

@linusha
Copy link
Contributor

linusha commented Dec 4, 2023

Aside from supporting the definition of components inside a workspace, it would also be nice to support the direct manipulation + reconciliation for the workspace.
Here again, we would face the nasty conflict between textual editing and direct manipulation, forcing the user again to temporarily pause the direct manipulation of components while they are editing.
One solution for mitigating this issue would be to introduce the concept of tiles (similar to the ones found in Jupyer Notebooks) where the component definitions can be isolated, so editing other tiles does not interfere with the direct manipulation session for editing a component.

Originally posted by @merryman in #510 (comment)

@linusha
Copy link
Contributor Author

linusha commented Dec 4, 2023

We decided on implementing a "ranged editing block" via a combination of ranges and anchors, that prevents users from editing a component definition manually when its reconciliation session is opened.
This has the benefit of working well for the workspaces as well as the system browser.

@merryman merryman added the ✨ enhancement New feature or request label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants