Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow starting to bundle from within lively.next again (future of the Freezer Prompt) #1223

Open
linusha opened this issue Jan 23, 2024 · 2 comments
Assignees
Labels
✨ enhancement New feature or request 💬 ideas welcome For feature ideas where more input on design decisions and conrete direction are warranted. 🐞 bug Something isn't working

Comments

@linusha
Copy link
Contributor

linusha commented Jan 23, 2024

Right now, the Freezer Prompt is in a rather precarious state. As the bundling options for projects are now laid out in (generated) build scripts, we should bring it back.
A first checklist of what this endeavor would entail follows:

The Prompt should at least be able to regenerate the buildscript with settings tweaked. We might also think about starting bundling processes via l2l from within lively.

It should be possible to configure

  • the excluded modules
  • minification?
  • the new verbosity flag?

The Prompt itself requires some work, we still have some now unsupported layouts in there I believe and bindings targeting viewModels as well.

Here's a screenshot pointing out some of the things that needs work:

Additionally, the prompt invocation right now is not right. I suggest to only make the freezer prompt available via the button in the browser when one is inside of module with a valid main function. Right now, the button is e.g., visible when one browses lively.morphic/index.js.

Thoughts, @merryman?

@linusha linusha added 🐞 bug Something isn't working ✨ enhancement New feature or request 💬 ideas welcome For feature ideas where more input on design decisions and conrete direction are warranted. labels Jan 23, 2024
@merryman merryman self-assigned this Feb 16, 2024
@rickmcgeer
Copy link
Collaborator

@merryman fixed the build script for https://github.com/engageLively/galyleo-dashboard (and thanks!) but the build script was put in the tools subdirectory of the project and only ran properly if it was invoked from the top-level directory. Now, [the project] (https://github.com/engageLively/galyleo-dashboard) is probably a one-off, since:

  1. We build several pages, not just one, from the project (studio-en, studio-jp, and publication)
  2. The project has been developed simultaneously with lively.next, and so of course as design decisions in lively.next change it still bears the mark of old code.

But still, I think it would be really useful to have a Freezer Guide which tells users how to freeze a project.

@linusha
Copy link
Contributor Author

linusha commented Apr 29, 2024

@rickmcgeer Duly noted, we will work put this on our list of proper documentation to write!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request 💬 ideas welcome For feature ideas where more input on design decisions and conrete direction are warranted. 🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants