Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server restart inside of test.sh does not work as expected #1526

Open
linusha opened this issue May 16, 2024 · 0 comments
Open

Server restart inside of test.sh does not work as expected #1526

linusha opened this issue May 16, 2024 · 0 comments
Assignees
Labels
🐞 bug Something isn't working

Comments

@linusha
Copy link
Contributor

linusha commented May 16, 2024

There are several problems with the way we handle server restarts in the test.sh script:

  • In the case that the CI env variable is not set, the server is not correctly shutdown.
  • In the case that the CI env variable is set, the server is not correctly shutdown when running the script locally. It is unclear why that works remotely, as starting a server locally after running the script does not succeed due to the port already being used.
  • I could reliably kill everything by invoking pkill -9 -f '.*lively.*' inside of the same shell that the script ran it previously. However, using the same line inside of the script did not always lead to the same result. I expect that this has something to do with subshells and the UNIX process hierarchy.
  • There is however an additional catch: The above command will not work as expected for the case that one starts the a new test server (running test.sh without the CI env variable set while another lively server is running on a port other than 9011), as this kills all lively servers. However, we need a command that only kills the one on 9011 and -n does not cut it, as we need to kill multiple processes.
@linusha linusha added the 🐞 bug Something isn't working label May 16, 2024
@linusha linusha self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant