Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transmuting pointers is (or will be?) unsound #64

Closed
Lokathor opened this issue Jun 8, 2021 · 1 comment
Closed

transmuting pointers is (or will be?) unsound #64

Lokathor opened this issue Jun 8, 2021 · 1 comment
Labels
bug Something isn't working The Language Could Change I Guess A change in the language could always potentially invalidate old code

Comments

@Lokathor
Copy link
Owner

Lokathor commented Jun 8, 2021

Ref: rust-lang/unsafe-code-guidelines#286

It seems we'll have to remove the Pod impls for pointers.

  • this is a breaking change
  • this is "allowed" as a break because it's a Soundness fix.
@Lokathor Lokathor added bug Something isn't working The Language Could Change I Guess A change in the language could always potentially invalidate old code labels Jun 8, 2021
@Lokathor
Copy link
Owner Author

Lokathor commented Jul 3, 2022

We removed this and pushed those impls behind a feature gate with the word "unsound" in the name. best we're gonna do in version 1 guess.

@Lokathor Lokathor closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working The Language Could Change I Guess A change in the language could always potentially invalidate old code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lokathor