Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: getDotLottieInstance should be defined (vue3) #187

Open
1 task done
emmanuelgeoffray opened this issue Apr 24, 2024 · 1 comment
Open
1 task done

TypeScript: getDotLottieInstance should be defined (vue3) #187

emmanuelgeoffray opened this issue Apr 24, 2024 · 1 comment
Assignees
@afsalz
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed vue

Comments

@emmanuelgeoffray
Copy link

Overview

image

The doc for the vue package mentions a getDotLottieInstance function but it is not in the component typing.

getDotLottieInstance is not defined, triggering TS issues and losing type.

I think that we should use defineExpose at this line

as explained in the Vue docs here

Consuming repo

dotlottie-vue

Labels

  • Add the Type: Bug label to this issue.
@theashraf theashraf added good first issue Good for newcomers bug Something isn't working labels Apr 24, 2024
@afsalz afsalz self-assigned this Apr 26, 2024
@theashraf theashraf added the help wanted Extra attention is needed label May 24, 2024
@theashraf
Copy link
Member

@afsalz any updates on this ?

@theashraf theashraf added the vue label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afsalz afsalz

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed vue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emmanuelgeoffray @theashraf @afsalz