Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties windows is broken? #8

Open
torrmercury opened this issue Feb 12, 2016 · 4 comments · May be fixed by #13
Open

Properties windows is broken? #8

torrmercury opened this issue Feb 12, 2016 · 4 comments · May be fixed by #13

Comments

@torrmercury
Copy link

Unsure if this is happening because of a strange interaction with my own machine or if this is a known issue.

properties is broken
@jerone
Copy link

jerone commented Feb 17, 2016

Same issue. Probably needs a theme update.

@mzmb
Copy link

mzmb commented Mar 17, 2016

Go to File > Settings > Packages > atom-json-editor
Press "View Code" button
Find atom-json-editor/lib/atom-json-editor.coffee
atom-json-editor coffee

Replace "bootstrap2" with "bootstrap3"
bootstrap3

Save changes and restart Atom

@jerone
Copy link

jerone commented Mar 17, 2016

Replace "bootstrap2" with "bootstrap3"

Not perfect, but much better. Thanks!

jfether added a commit to jfether/atom-json-editor that referenced this issue Jan 6, 2017
@jfether
Change bootstrap2 theme to bootstrap3 theme
b3f1659 
Provides a visual improvement in the Properties window, which under the "bootstrap2" theme had checkboxes inappropriately placed over the list of properties rather than to the left of them. This fixes LukasHechenberger#8, and was suggested by @mzmb in the comments for issue LukasHechenberger#8.
@jfether jfether linked a pull request Jan 6, 2017 that will close this issue
Open
@jfether
Copy link

jfether commented Jan 6, 2017

@mzmb I have created a pull request incorporating your fix and appropriately crediting you for this. I tested it myself and the result was a marked improvement over the previous behaviour of the UI. Thank you for your research.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change bootstrap2 theme to bootstrap3 theme jfether/atom-json-editor
4 participants
@jerone @torrmercury @jfether @mzmb