Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Header #36

Open
Kirill-frontend opened this issue Jan 19, 2021 · 6 comments
Open

Fixed Header #36

Kirill-frontend opened this issue Jan 19, 2021 · 6 comments

Comments

@Kirill-frontend
Copy link
Contributor

I have a suggestion for a header element
It looks pretty good in my opinion

@BenDMyers
Copy link
Member

Hey, @Kirill-frontend! What's your suggestion?

@Kirill-frontend
Copy link
Contributor Author

Make the header element fixed on the site

image

@chantastic
Copy link
Contributor

i'm good with that.

maybe progressively enhanced with position: sticky?

@Kirill-frontend
Copy link
Contributor Author

Kirill-frontend commented Jan 20, 2021

position: fixed;
Will it be more cross-browser or doesn't matter?

@chantastic
Copy link
Contributor

good question, @Kirill-frontend

i think you're right that position: fixed would have better cross-browser compatibility.
but the fallback experience for browsers that don't support sticky is fine.

one thing i prefer about sticky is that the element is not removed from the document flow (like fixed does.

@Kirill-frontend
Copy link
Contributor Author

Clear. I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants