Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI's expected 24-hour format is unclear #65

Open
BenDMyers opened this issue Jan 29, 2021 · 1 comment
Open

CLI's expected 24-hour format is unclear #65

BenDMyers opened this issue Jan 29, 2021 · 1 comment
Assignees
Labels
cli Bugs/features for the event creation command line tool

Comments

@BenDMyers
Copy link
Member

When you generate an event using the CLI, the following prompt asks you to provide a start time:

What hh or hh:mm (10 or 10:30)?

This prompt is expecting a time in a 24-hour clock format, but it doesn't make that clear. This hasn't been an issue for our PST and CST friends, who have usually entered "10:00" and "12:00" respectively. However, when our EST friends enter "1:00," they're providing 1:00 am.

We should make this experience a little clearer. There are a couple ways I could see us doing this.

  • Including a note in the prompt that specifies the format should use a 24-hour clock
  • Giving the user a radio prompt to select AM or PM
  • Having the user type "am" or "pm" when entering a time (would also need to be mentioned in the prompt)

I'm fine with any of these approaches - if you pick this up, choose your favorite approach.

@BenDMyers BenDMyers added the cli Bugs/features for the event creation command line tool label Jan 29, 2021
@BenDMyers BenDMyers changed the title Make 24-hour clock or AM/PM selection clearer in CLI CLI's expected 24-hour format is unclear Jan 29, 2021
@msutkowski msutkowski self-assigned this Jan 30, 2021
@msutkowski
Copy link
Member

Will take this over... it touches on what I'm doing for the speakers tomorrow 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Bugs/features for the event creation command line tool
Projects
None yet
Development

No branches or pull requests

2 participants