Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight all suspense events related to a wakeable when one is highlighted #44

Closed
taneliang opened this issue Jul 3, 2020 · 1 comment · Fixed by #111
Closed

Highlight all suspense events related to a wakeable when one is highlighted #44

taneliang opened this issue Jul 3, 2020 · 1 comment · Fixed by #111
Assignees
@taneliang
Labels
importance: 2 - should have This should be implemented, but we will still have a working product if we don't phase: 2 - iteration Iterations on our MVP urgency: 3 - within 2 weeks work type: implementation A task that primarily involves bashing code
Projects
React Concurrent Mode Profiler

Comments

@taneliang
Copy link
Member

taneliang commented Jul 3, 2020 •
edited

From facebook/react#19223 (comment):

... I think it could be useful if we highlighted all suspense events related to the wakeable when one of them is hovered over. It's currently not possible to tell when a suspense event resolves/rejects, especially if there are many instances of the same component suspending in quick succession.

image

Related suspense events share the same wakeable ID. We can use that to identify related suspense events and highlight them all when one is highlighted.

Acceptance Criteria

  • When a suspense event is moused over, all suspense events with the same id should be highlighted.
  • No Flow errors in affected code.
@taneliang taneliang created this issue from a note in React Concurrent Mode Profiler (To do) Jul 3, 2020
@kartikcho kartikcho self-assigned this Jul 6, 2020
@taneliang taneliang added phase: 2 - iteration Iterations on our MVP urgency: 4 - no urgency We have an indefinite amount of time to complete this importance: 2 - should have This should be implemented, but we will still have a working product if we don't work type: implementation A task that primarily involves bashing code urgency: 3 - within 2 weeks and removed urgency: 4 - no urgency We have an indefinite amount of time to complete this labels Jul 8, 2020
@taneliang taneliang mentioned this issue Jul 21, 2020
Closed
4 tasks
@kartikcho kartikcho moved this from To do to In progress in React Concurrent Mode Profiler Jul 21, 2020
@kartikcho kartikcho moved this from In progress to To do in React Concurrent Mode Profiler Jul 27, 2020
@kartikcho kartikcho moved this from To do to In progress in React Concurrent Mode Profiler Jul 28, 2020
@taneliang
Copy link
Member Author

Reassigning to me as discussed with @kartikcho on Discord.

@taneliang taneliang assigned taneliang and unassigned kartikcho Aug 3, 2020
taneliang added a commit that referenced this issue Aug 3, 2020
@taneliang
Highlight React events with the same wakeable ID
a6c79cb 
Summary
---

Resolves #44.

Intended to highlight all related React events. However, it looks like
separate promises can have the same wakeable ID, which is a bit strange.

TODO
---

* Ensure that we are correctly understanding wakeable IDs, i.e. that
  a unique resource/promise is a unique wakeable.
* Check if `unstable_createResource` caches promises.

Test Plan
---

* `yarn lint`
* `yarn flow`: no errors in changed code
@taneliang taneliang mentioned this issue Aug 3, 2020
Merged
@taneliang taneliang linked a pull request Aug 3, 2020 that will close this issue
Highlight React events with the same wakeable ID #111
Merged
taneliang added a commit that referenced this issue Aug 3, 2020
@taneliang
Highlight React events with the same wakeable ID
bdcbfc5 
Summary
---

Resolves #44.

Intended to highlight all related React events. However, it looks like
separate promises can have the same wakeable ID, which is a bit strange.

TODO
---

* Ensure that we are correctly understanding wakeable IDs, i.e. that
  a unique resource/promise is a unique wakeable.
* Check if `unstable_createResource` caches promises.

Test Plan
---

* `yarn lint`
* `yarn flow`: no errors in changed code
@taneliang taneliang mentioned this issue Aug 4, 2020
Open
3 tasks
taneliang added a commit that referenced this issue Aug 4, 2020
@taneliang
Highlight React events with the same wakeable ID
e6546e6 
Summary
---

Resolves #44.

Intended to highlight all related React events. However, it looks like
separate promises can have the same wakeable ID, which is a bit strange.

TODO
---

* Ensure that we are correctly understanding wakeable IDs, i.e. that
  a unique resource/promise is a unique wakeable.
* Check if `unstable_createResource` caches promises.

Test Plan
---

* `yarn lint`
* `yarn flow`: no errors in changed code
React Concurrent Mode Profiler automation moved this from In progress to Done Aug 4, 2020
taneliang added a commit that referenced this issue Aug 4, 2020
@taneliang
Highlight React events with the same wakeable ID (#111)
0660603 
Summary
---

Resolves #44.

Intended to highlight all related React events. However, it looks like
separate promises can have the same wakeable ID, which is a bit strange.

TODO
---

* Ensure that we are correctly understanding wakeable IDs, i.e. that
  a unique resource/promise is a unique wakeable.
* Check if `unstable_createResource` caches promises.

Test Plan
---

* `yarn lint`
* `yarn flow`: no errors in changed code
@kartikcho kartikcho mentioned this issue Aug 21, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taneliang taneliang

Labels
importance: 2 - should have This should be implemented, but we will still have a working product if we don't phase: 2 - iteration Iterations on our MVP urgency: 3 - within 2 weeks work type: implementation A task that primarily involves bashing code
Projects
No open projects
React Concurrent Mode Profiler
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Highlight React events with the same wakeable ID MLH-Fellowship/scheduling-profiler-prototype
2 participants
@taneliang @kartikcho