Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-Order] Setup order implementation #36

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[R-Order] Setup order implementation #36

wants to merge 11 commits into from

Conversation

MNThomson
Copy link
Owner

@MNThomson MNThomson commented Aug 23, 2022 •
edited

Description

Create a working order implementation

Closes #31
Closes #17

Checklist

  • The code follows all style guidelines.
  • The code passes all required tests.
  • The code is documented.
  • The code includes tests.
  • I have self-reviewed my changes and have done QA.

General Comments

@MNThomson MNThomson self-assigned this Aug 23, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 23, 2022
View reviewed changes
internal/utils/utils.go

case reflect.Int:
if val, err := strconv.ParseInt(defaultVal, 10, 64); err == nil {
field.Set(reflect.ValueOf(int(val)).Convert(field.Type()))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of a 64-bit integer from [strconv.ParseInt](1) to a lower bit size type int without an upper bound check.
This was referenced Jan 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MNThomson MNThomson

Labels
dependencies examples provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource Order doesn't actually order pizza Remove CC input
1 participant
@MNThomson