Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to add _start_tls_compatible attribute to TCPTransport? #588

Open
rahuliyer95 opened this issue Jan 3, 2024 · 0 comments
Open

Comments

@rahuliyer95
Copy link

  • uvloop version: 0.19.0
  • Python version: 3.10.7
  • Platform: Linux
  • Can you reproduce the bug with PYTHONASYNCIODEBUG in env?: Yes
  • Does uvloop behave differently from vanilla asyncio? How?: Yes

aiohttp (3.9.1) keeps warning (falsely) about 1

RuntimeWarning: An HTTPS request is being sent through an HTTPS proxy. This support for TLS in TLS is known to be disabled in the stdlib asyncio (Python <3.11). This is why you'll probably see an error in the log below.

It throws this warning because it's not able to find _start_tls_compatible property on the TCPTransport object (https://github.com/aio-libs/aiohttp/blob/v3.9.1/aiohttp/connector.py#L1054). The same property is present when asyncio is used which provides SelectorSocketTransport as the underlying transport. Is it possible to provide the _start_tls_compatible attribute on the TCPTransport which can help us avoid this warning?

Footnotes

  1. https://github.com/aio-libs/aiohttp/discussions/6044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant