Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uvloop fails to build with Python 3.13.0a5: error: implicit declaration of function ‘_Py_RestoreSignals’ #603

Open
befeleme opened this issue Mar 27, 2024 · 2 comments · May be fixed by #604
Open

uvloop fails to build with Python 3.13.0a5: error: implicit declaration of function ‘_Py_RestoreSignals’ #603

befeleme opened this issue Mar 27, 2024 · 2 comments · May be fixed by #604

Comments

@befeleme
Copy link

  • uvloop version: 0.19.0
  • Python version: 3.13.0a5
  • Platform: Fedora Linux 41
  • Can you reproduce the bug with PYTHONASYNCIODEBUG in env?: n/a
  • Does uvloop behave differently from vanilla asyncio? How?: n/a

I try to build uvloop for Fedora Linux 41 with Python 3.13.0a5.
The build fails with the information below.

  uvloop/loop.c: In function ‘__pyx_f_6uvloop_4loop_9UVProcess__after_fork’:
  uvloop/loop.c:129617:5: error: implicit declaration of function ‘_Py_RestoreSignals’ [-Werror=implicit-function-declaration]
  129617 |     _Py_RestoreSignals();
         |     ^~~~~~~~~~~~~~~~~~
@befeleme
Copy link
Author

_Py_RestoreSignals() has apparently been moved to internal CPython: python/cpython@c9ce983

@hroncok
Copy link
Contributor

hroncok commented Apr 30, 2024 •
edited

https://github.com/python/cpython/blob/v3.13.0a6/Modules/signalmodule.c#L1931-L1951

Maybe this can be inlined?

@befeleme befeleme linked a pull request Apr 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inline _Py_RestoreSignals() from CPython befeleme/uvloop
2 participants
@hroncok @befeleme