Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update electron to 22.0.0 #82

Closed
yanguoyu opened this issue Dec 6, 2022 · 4 comments
Closed

Update electron to 22.0.0 #82

yanguoyu opened this issue Dec 6, 2022 · 4 comments
Assignees
@yanguoyu
Labels
update dependency update dependency
Milestone
2022/12/07 - 2022...

Comments

@yanguoyu
Copy link

yanguoyu commented Dec 6, 2022

It's better to update the dependence to the latest stable version.
Finish it to close nervosnetwork/neuron#2525.
@yanguoyu yanguoyu added the update dependency update dependency label Dec 6, 2022
@yanguoyu
Copy link
Author

  1. sandbox preloads by default
  2. chore(deps-dev): bump electron from 16.2.8 to 18.3.7 nervosnetwork/neuron#2525 (comment)

@yanguoyu
Copy link
Author

There is an issue electron/electron#33685, but it seems not to affect functions.
image

@yanguoyu yanguoyu self-assigned this Dec 13, 2022
@yanguoyu yanguoyu added this to the 2022/12/07 - 2022-12/14 milestone Dec 13, 2022
@Keith-CY
Copy link
Member

There is an issue electron/electron#33685, but it seems not to affect functions. image

It would be fine if UI is rendered as expected. I've tracked some issues of this bug and found UI should be broken into a blank screen if this it is triggered.

@yanguoyu
Copy link
Author

nervosnetwork/neuron#2544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanguoyu yanguoyu

Labels
update dependency update dependency
Projects
Neuron
Archived in project
Nervos Wallet/Explorer
Status: Pre-release
Milestone
2022/12/07 - 2022-12/14
Development

No branches or pull requests
2 participants
@Keith-CY @yanguoyu