The reviewer rules

[ming-tsai]

In this discussion, we are going to talk about the rules of being a reviewer.

1. The recent change of file should be the reviewer.
2. Don't review what another reviewer has already reviewed, at least you find a mistake or other reviewer might have missed
3. Do the changes mentioned by @...
4. DO NOT merge the pull request that is already accepted.

Please add your suggetions:
@Arsenic-ATG, @UG-SEP, @aayushjain7, @TawfikYasser, @cyberwizard1001, @atin, @paulsonjpaul, @sridhar-5

[Arsenic-ATG]

2. Do not review if someone is reviewing, at least the reviewer approved the pull request but it has a better way to code

I think instead of this, it should be " don't review what other reviewers have already reviewed. ". I don't see a problem if someone else find a mistake which other reviewer might have missed ( after all we are humans ). More reviewer will only mean more checks before getting the changes accepted, but if all of them point out same thing or just say " do the changes mentioned by @... " then it can become a mess.

[ming-tsai]

I have updated

[ming-tsai]

The second suggestion, I mean if someone approved it, another one review the pull request and doesn't find out any problem, you don't have approved it

[TawfikYasser]

Hi @ming-tsai I'm totally agree with you.

[cyberwizard1001]

Hi, @ming-tsai, I feel suggestions to improvement are always welcome irrespective of when its being given. I agree with @Arsenic-ATG , suggestions like "Please implement what @x said" can be avoided, genuine comments can be welcome.

[UG-SEP]

@ming-tsai @Arsenic-ATG @cyberwizard1001 @TawfikYasser Yes, You all are right.
If I have done any mistake then please forgive me i will follow all the rules from now

[aayushjainx]

Agreed! Will follow rules from now. 💯

[ming-tsai]

Hi @Waqar-107,
Do you want to be a C# reviewer?

[Waqar-107]

@ming-tsai sure!