Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken mobile layout #57

Open
AmeliaBR opened this issue Jul 28, 2020 · 1 comment
Open

Broken mobile layout #57

AmeliaBR opened this issue Jul 28, 2020 · 1 comment
Assignees
@nchan0154
Labels
bug Something isn't working

Comments

@AmeliaBR
Copy link
Member

It looks like when I added the “Register Now” CTA, I didn't check all the responsive breakpoints & my grid layout ended up with a mostly empty column in mobile view. 🙈

I'm pretty sure this is just a case of finding the grid-areas declarations in the CSS & fixing one or two lines. @nchan0154 , could you tackle this first thing?

Screenshote, top of page, showing the empty column
Screenshot, bottom of the page, showing the offending register now box as the only item in that column
@AmeliaBR AmeliaBR added the bug Something isn't working label Jul 28, 2020
nchan0154 added a commit to nchan0154/Maps4HTML-Workshop-2020 that referenced this issue Jul 28, 2020
@nchan0154
[Maps4HTML#57] Fix mobile breakpoint
5598f1b
@nchan0154 nchan0154 mentioned this issue Jul 28, 2020
Merged
@Malvoz
Copy link
Member

Malvoz commented Mar 30, 2021

This seems to have been fixed, can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nchan0154 nchan0154

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AmeliaBR @nchan0154 @Malvoz