Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map-change should only get emitted when user interacts, similar to change event from HTML #139

Open
AliyanH opened this issue Nov 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@AliyanH
Copy link
Member

AliyanH commented Nov 15, 2023

currently our map-change event gets emitted every time the attributeChangedCallback for the checked attribute is invoked, which can be through the API, keyboard navigation or click.

For the HTML change event, it is only emitted by user interactions, unlike our map-change event which can be emitted by even the API.
image

We need to refactor our event use to either use a new event or change our current implementation

@AliyanH AliyanH added the enhancement New feature or request label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant