Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute to the gallery #28

Open
fallenleaves404 opened this issue Feb 6, 2020 · 3 comments
Open

Contribute to the gallery #28

fallenleaves404 opened this issue Feb 6, 2020 · 3 comments

Comments

@fallenleaves404
Copy link

Hi, I also want to contribute my interactive project to the gallery!

Web: https://nyc-airbnb-analysis.herokuapp.com/
Github: https://github.com/fallenleaves404/NYC_Airbnb_Analysis

If I need some revision, please let me know!

And also thanks to @lyqht, for inspiring me to build a project

@lyqht
Copy link
Contributor

lyqht commented Feb 7, 2020

Oh wow, I'm surprised that my mediocre project could inspire you to build one 😄 Streamlit's capabilities are really amazing!

Some feedback from me about your project:

  • title of graphs should be more consistent (some are above the plot, some below the x-axis)
  • units of your plots (e.g. price in __$)
  • num of house in diff area plot extends out of the page boundary
  • the interact example is beautiful! ❤️
  • the navigation items could be better named

nice!

@fallenleaves404
Copy link
Author

Yeah, your project really help me a lot! I'm new to GitHub and don't know how to organize the repository. I learn many things from your project!

Thanks for your feedback! I have improved the points you mention

@MarcSkovMadsen
Copy link
Owner

MarcSkovMadsen commented Feb 8, 2020

I am on holiday the next week. But @lyqht and @fallenleaves404 its so inspiring to see your conversion, so maybe you can help each other move this forward in the mean time.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants