Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow declaring "version groups" for packages #1023

Open
epage opened this issue Oct 6, 2023 · 2 comments
Open

Allow declaring "version groups" for packages #1023

epage opened this issue Oct 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@epage
Copy link

epage commented Oct 6, 2023

Motivations

When dealing with proc-macros, its common to have the package that re-exports it to have its version in lockstep with the proc macro package. You can use workspace.package.version for this but that doesn't scale if you have other content in the repo (e.g. clap).

Note: just because they are in the group, doesn't mean all members have to release.

  • Would you like to implement this feature? maybe

Solution

cargo-release generalized workspace.package.version support into the package config field shared-version which can either be true or be a named group (with workspace versions being "workspace")

Alternatives

Additional context

@epage epage added the enhancement New feature or request label Oct 6, 2023
@MarcoIeni
Copy link
Owner

Ok, so this feature allows groups of packages to share the same version, that can be different from workspace.package.version.

Sounds good and PR is welcome!

We can add the shared-version field to the package section of the config file.

One note: I don't think that true is needed, because you could set version.workspace = true in the Cargo.toml, right?

@epage
Copy link
Author

epage commented Oct 7, 2023

Yes, the bool state isn't strictly needed. In part, that came from how it evolved in cargo-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants