Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating custom version fields #1024

Open
epage opened this issue Oct 6, 2023 · 2 comments
Open

Allow updating custom version fields #1024

epage opened this issue Oct 6, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@epage
Copy link

epage commented Oct 6, 2023

Motivations

Before cargo add, it was common to have a manifest snippet with a version in it. There are still other cases of versions and other relevant information appearing in repos, like citation files.

  • Would you like to implement this feature? maybe

Solution

cargo-release has a "pre-release replacements" set of regexes (example)

Alternatives

Hooks for running external programs. This exists in cargo-release but I never use it because its hard to do these cross-platform

Additional context

@epage epage added the enhancement New feature or request label Oct 6, 2023
@MarcoIeni
Copy link
Owner

MarcoIeni commented Oct 7, 2023

This sounds good to me.
We can call this field replacements in the config file and we can apply these replacements in the release-plz update command (and also release-pr). No need to support the command line argument.
These options look good, except from the prerelease one which doesn't apply for release-plz.
PR welcome!

@MarcoIeni MarcoIeni added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 7, 2023
@ruben-arts
Copy link

I'm also looking for this feature, also for the CITATION.cff but also possibly other files.

Next to that I'm also interested in the hooks, e.g. for bumping documentation.

Big thumbs up from me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants