-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "git only" mode #1144
Comments
Thanks for opening this. I am interested in working on it. |
In case it is helpful, on the CLI version, there is a relevant flag The explanation for that flag is:
|
Hey @jdidion do you still work on this? |
Hi Marco, yes I've been working on it slowly. Just created a draft PR so you can see the progress #1227. Tl;dr right now I have:
Now I'm looking at how to actually implement |
Thanks @ozgunozerk I'll take a look at that option. Maybe the implementation of that option will hint at how I should implement git-only. |
So far the PR looks great!
Yes, I think that would help.
I prefer enum because they are simpler, but whatever it works for you it's fine :) I would say, let's not overthink it. First let's get it working, and we can refine later :) |
Seems like this issue is stale again. I can take over, but what I had in mind overwrites some work @jdidion already did. If he does not have enough time to continue on this, I already have a good understanding of the repo and the issue, and I can take over. |
Hey Özgün, great to see you're still interested in working on this. Feel free to take over. |
Motivations
Some people want to use release-plz without publishing on crates.io. We could use git tags as the source of truth.
Solution
git_only
configuration flag at the workspace level, that you can also override for each package. Values:true
orfalse
. False by default.git-only
mode is onpublish = false
in the Cargo.toml ifgit-only
is on for that package.Additional context
Created from the discussion in #590 (comment) and #1139
The text was updated successfully, but these errors were encountered: