Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab support #587

Open
1 of 2 tasks
MarcoIeni opened this issue Mar 5, 2023 · 4 comments
Open
1 of 2 tasks

Add GitLab support #587

MarcoIeni opened this issue Mar 5, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed priority:low This can wait

Comments

@MarcoIeni
Copy link
Owner

MarcoIeni commented Mar 5, 2023

Motivations

release-plz supports GitHub and Gitea.
I'm not familiar GitLab, so I haven't add support for it.
However if you want to use release-plz with GitLab, tell me how the integration should work.

Here are the API calls we use for GitHub and Gitea.
What's the equivalent in GitLab?
Should we create the equivalent of the GitHub action for the GitLab CI?

We need to add support for these commands:

@MarcoIeni MarcoIeni added enhancement New feature or request good first issue Good for newcomers labels Mar 5, 2023
@MarcoIeni MarcoIeni added the priority:low This can wait label Apr 10, 2023
@MarcoIeni MarcoIeni removed the good first issue Good for newcomers label May 2, 2023
@D-J-Harris
Copy link

What is the status of release-pr command not being ready? I see there is some support in core for it

@MarcoIeni
Copy link
Owner Author

The support in core is for the release-plz release command.
Regarding the release-pr I don't even know how release-plz should work on GitLab, as I'm not familiar with the platform (how PRs look on GitLab?).
I also don't plan to work on this, since I don't have a use case for it (see the priority:low tag).
Of course, I'm happy to help someone who wants to work on this.

@MarcoIeni MarcoIeni added the help wanted Extra attention is needed label Feb 14, 2024
@magikmw
Copy link

magikmw commented Apr 24, 2024

I'll carve out some time to take a look, at least to provide some gitlab usage knowledge and feedback on what needs to be done for their API.

I do have a specific question - how likely are we to use a dependency specific to gitlab API (if one exists in rust, so far I only used a python implementation)?

@MarcoIeni
Copy link
Owner Author

Thanks for that!
I would like to avoid using a gitlab library to keep the number of release-plz dependencies low (we don't use libraries for github or gitea as well).

If you want to raise a PR and you want to use a gitlab library for fast-prototyping, feel free. We can remove the dependency later. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed priority:low This can wait
Projects
None yet
Development

No branches or pull requests

3 participants