Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude ignored files using cargo package list #1089

Merged
merged 22 commits into from
Nov 30, 2023

Conversation

lutaok
Copy link
Contributor

@lutaok lutaok commented Nov 25, 2023

Hello,
Opening this PR to fix #721

Changes:

  • used cargo package --list to get files from local and registry packages
  • ignored Cargo.toml.orig, .cargo_vcs_info.json and Cargo.lock files
  • Removed directory traversing walker while checking diffs

Thanks for the guidance @MarcoIeni !

@MarcoIeni
Copy link
Owner

This is such a great improvement. I tried running release-plz in the tokio repository after this change, and I can see that the result looks much better because release-plz ignores the fuzz directory, which is indeed not published to crates.io (but still is a subdirectory of the tokio crate). 🎉

Thanks for working on this 🙏
I just did a couple of changes to refactor and a few minor fixes.

@MarcoIeni MarcoIeni merged commit efd7599 into MarcoIeni:main Nov 30, 2023
13 checks passed
@MarcoIeni MarcoIeni mentioned this pull request Nov 30, 2023
4 tasks
@release-plz release-plz bot mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't commit excluded files
2 participants