Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement encoding.TextMarshaler and encoding.TextUnmarshaler #173

Conversation

MarkRosemaker
Copy link
Contributor

@MarkRosemaker MarkRosemaker commented May 28, 2022

This PR implements encoding.TextMarshaler and encoding.TextUnmarshaler for semver.Version.

This now allows marshalling and unmarshalling yaml, which was tested using three different yaml libraries.

@MarkRosemaker MarkRosemaker changed the title Implement encoding.text marshaler and encoding.text unmarshaler Implement encoding.TextMarshaler and encoding.TextUnmarshaler May 28, 2022
@mh-cbon
Copy link
Contributor

mh-cbon commented May 28, 2022

you need not to add the dependencies to the tree.

that previous pr did similar, you could have a look #131

version_test.go Outdated Show resolved Hide resolved
version.go Show resolved Hide resolved
@MarkRosemaker
Copy link
Contributor Author

you need not to add the dependencies to the tree.

that previous pr did similar, you could have a look #131

Thank you for your prompt feedback, @mh-cbon! I've simplified the PR so we don't have any dependencies.

@MarkRosemaker
Copy link
Contributor Author

Thanks for the review, @mh-cbon ! Can we merge this?

@MarkRosemaker
Copy link
Contributor Author

What do you think, @mattfarina? Can we merge this?

@MarkRosemaker
Copy link
Contributor Author

@mh-cbon @mattfarina What is the process to merge a PR? I can't seem to be able to merge this since I lack write access.

piccobit added a commit to piccobit/semver that referenced this pull request Jul 26, 2022
Merged PR Masterminds#173 of upstream repository
@mattfarina mattfarina merged commit 2084c82 into Masterminds:master Nov 28, 2022
@MarkRosemaker MarkRosemaker deleted the implement-encoding.TextMarshaler-and-encoding.TextUnmarshaler branch March 23, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants