From d1a9a0e53225d7810c4f5e1136db32f4e360c5bb Mon Sep 17 00:00:00 2001
From: Valentin Chashchin <34175644+x-foby@users.noreply.github.com>
Date: Sat, 28 Nov 2020 00:27:44 +0300
Subject: [PATCH] Added paren for select statement in set clause (#263)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Чащин Валентин Валерьевич <valentin.chashchin@goods.ru>
---
 update.go      | 6 +++++-
 update_test.go | 4 +++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/update.go b/update.go
index e4927d7..70b6f68 100644
--- a/update.go
+++ b/update.go
@@ -86,7 +86,11 @@ func (d *updateData) ToSql() (sqlStr string, args []interface{}, err error) {
 			if err != nil {
 				return "", nil, err
 			}
-			valSql = vsql
+			if _, ok := vs.(SelectBuilder); ok {
+				valSql = fmt.Sprintf("(%s)", vsql)
+			} else {
+				valSql = vsql
+			}
 			args = append(args, vargs...)
 		} else {
 			valSql = "?"
diff --git a/update_test.go b/update_test.go
index 8b8950d..11955d4 100644
--- a/update_test.go
+++ b/update_test.go
@@ -14,6 +14,7 @@ func TestUpdateBuilderToSql(t *testing.T) {
 		SetMap(Eq{"c": 2}).
 		Set("c1", Case("status").When("1", "2").When("2", "1")).
 		Set("c2", Case().When("a = 2", Expr("?", "foo")).When("a = 3", Expr("?", "bar"))).
+		Set("c3", Select("a").From("b")).
 		Where("d = ?", 3).
 		OrderBy("e").
 		Limit(4).
@@ -27,7 +28,8 @@ func TestUpdateBuilderToSql(t *testing.T) {
 		"WITH prefix AS ? " +
 			"UPDATE a SET b = ? + 1, c = ?, " +
 			"c1 = CASE status WHEN 1 THEN 2 WHEN 2 THEN 1 END, " +
-			"c2 = CASE WHEN a = 2 THEN ? WHEN a = 3 THEN ? END " +
+			"c2 = CASE WHEN a = 2 THEN ? WHEN a = 3 THEN ? END, " +
+			"c3 = (SELECT a FROM b) " +
 			"WHERE d = ? " +
 			"ORDER BY e LIMIT 4 OFFSET 5 " +
 			"RETURNING ?"