New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with parser on newer versions of Electron #23
Comments
I've been hitting the same issue as well. Any update on if/when this will be addressed? |
Just checked with debug mode and found issue on this line, which is i think related to Electron (Github Issue) |
Which versions of Node are used in Electron 3.x and 4.x ? |
https://github.com/electron/node Node 10.11 is used in Electron 4.0.x |
Like @nshelia and @chevonc have referenced, calling |
Ahh, good to know @jamesb3ll. it seems that there's some traction on the Electron PR, but may try out this workaround for now if they don't merge in a couple of days. |
It seems that the fix was shipped in Electron 4.0.5 and Electron 5.0.0-beta.3. @DreamitMauri @chevonc @nshelia @jamesb3ll could you try if upgrading Electron fixes this issue ? |
Hey @MatthieuLemoine, I don't think that #16912 and #16909 that was fixed in Electron 4.0.5 or 5.0.0-beta.3 is related to this issue. As pointed out here by @nornagon, that works on Electron. I think solving #16477 would fix the problem, it seems to be related to compatibility of node/v8's Buffer patches in Electron v4+. I'm not sure quite how to solve it and waiting for a reply from @codebytere in that issue. |
Fix for this was merged if anyone else arrives here: https://github.com/electron/electron/releases/tag/v4.1.0 |
Confirmed. Fixed in Electron 4.1.0. |
Using this package on Electron 3x or 4x results in the app crashing with the following error message:
After digging around the source code I've isolated the problem to somewhere in the Parser.
Enabling debugging in the parser gives these messages:
The text was updated successfully, but these errors were encountered: