Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift 5.1] Import FoundationXML rather than Foundation #121

Closed
jsbean opened this issue Aug 5, 2019 · 7 comments
Closed

[Swift 5.1] Import FoundationXML rather than Foundation #121

jsbean opened this issue Aug 5, 2019 · 7 comments
Assignees

Comments

@jsbean
Copy link
Contributor

jsbean commented Aug 5, 2019

As of this PR onto the Swift 5.1 branch, XMLParser lives in a split-off FoundationXML framework rather than Foundation.

Once Swift 5.1 drops, perhaps we check against the compiler version to import accordingly?

This is a reality as of DEVELOPMENT-SNAPSHOT-2019-08-03-a.

@MaxDesiatov MaxDesiatov self-assigned this Aug 5, 2019
@MaxDesiatov
Copy link
Collaborator

As far as I understand, the recommended way is to use canImport like this:

#if canImport(FoundationXML)
import FoundationXML
#endif

Probably can even be included before 5.1 release.

@mxcl
Copy link

mxcl commented Sep 24, 2019

5.1 was released. Can submit PR. Need it for production use of this library.

@MaxDesiatov
Copy link
Collaborator

MaxDesiatov commented Sep 25, 2019

@mxcl very excited to see this library in production! Please let me know if that's public, I'd be happy to feature it in the README file.

5.1 support for Linux is in master now and I plan to tag a new release with that ASAP.

@mxcl
Copy link

mxcl commented Sep 25, 2019

Use is private currently, will advise when we're more public! Thanks for the lib, was essential for our backend services.

@jsbean
Copy link
Contributor Author

jsbean commented Sep 28, 2019

@MaxDesiatov, looks like you took care of this in #133! Want me to close this down, or is there anything else that needs to be done?

@MaxDesiatov
Copy link
Collaborator

@jsbean, thanks for checking! I'll keep this open until 0.9 is formally released, primarily as a reminder for this to be added to the CHANGELOG file etc.

@MaxDesiatov
Copy link
Collaborator

Closing as fixed in the imminent 0.9 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants