Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float vs Float64=Double not parsing 3.14 #130

Closed
marcblanchet opened this issue Sep 13, 2019 · 1 comment · Fixed by #138
Closed

Float vs Float64=Double not parsing 3.14 #130

marcblanchet opened this issue Sep 13, 2019 · 1 comment · Fixed by #138
Assignees
@MaxDesiatov
Labels
bug Something isn't working

Comments

@marcblanchet
Copy link

if string = "3.14" (which is a valid Float literal), and Codable class contains var myFloat: Float?, on MacOSX 10.14, it does not parse. If I change "typealias Unboxed = Float64" (Float64 seems to be Double from Apple) to Float like: "typealias Unboxed = Float" in FloatBox.swift , then parsing works.
@MaxDesiatov MaxDesiatov mentioned this issue Oct 5, 2019
Merged
@MaxDesiatov MaxDesiatov self-assigned this Oct 5, 2019
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Oct 5, 2019
@MaxDesiatov
Copy link
Collaborator

Hi @marcblanchet, thanks for reporting this, this is fixed in #138.

MaxDesiatov added a commit that referenced this issue Oct 6, 2019
@MaxDesiatov
Fix Float32 decoding, add DoubleBox (#138)
9e680f2 
Resolve #130.

Also make `xmlString` function a computed property.
bwetherfield pushed a commit to bwetherfield/XMLCoder that referenced this issue Oct 16, 2019
@MaxDesiatov @bwetherfield
Fix Float32 decoding, add DoubleBox (CoreOffice#138)
ee4cdd7 
Resolve CoreOffice#130.

Also make `xmlString` function a computed property.
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this issue Jun 26, 2020
@MaxDesiatov
Fix Float32 decoding, add DoubleBox (CoreOffice#138)
caf4e27 
Resolve CoreOffice#130.

Also make `xmlString` function a computed property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxDesiatov MaxDesiatov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Float32 decoding, add DoubleBox CoreOffice/XMLCoder
2 participants
@MaxDesiatov @marcblanchet