Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change components variable from var to let #107

Merged
merged 1 commit into from Jun 21, 2019

Conversation

jayhickey
Copy link
Contributor

Fixes a compiler warning; this is never mutated so it can be changed to let

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files          38       38           
  Lines        2054     2054           
=======================================
  Hits         1566     1566           
  Misses        488      488
Impacted Files Coverage Δ
Sources/XMLCoder/Decoder/XMLDecoder.swift 77.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9efd7...d73315a. Read the comment docs.

Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for the contribution!

@MaxDesiatov MaxDesiatov merged commit 1d1faeb into CoreOffice:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants