Keep the order of the attributes during encoding operations #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 76.24% 76.21% -0.03%
==========================================
Files 38 38
Lines 2054 2052 -2
==========================================
- Hits 1566 1564 -2
Misses 488 488
Continue to review full report at Codecov.
|
MaxDesiatov
approved these changes
Jun 30, 2019
arjungupta0107
pushed a commit
to salido/XMLCoder
that referenced
this pull request
Jun 26, 2020
…ce#110) This PR fixes CoreOffice#108 by replacing the unordered data structure used for storing the attributes (a Swift `Dictionary`) with an ordered data structure: an array of `Attribute` structs. * Added tests to validate attribute order when encoding * Fix CoreOffice#108 * Improved encapsulation of XMLCoderElement's properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #108 by replacing the unordered data structure used for storing the attributes (a Swift
Dictionary) with an ordered data structure: an array ofAttributestructs.