Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: errorContextLenght -> errorContextLength #114

Merged
merged 1 commit into from Jul 13, 2019
Merged

Fix typo: errorContextLenght -> errorContextLength #114

merged 1 commit into from Jul 13, 2019

Conversation

jsbean
Copy link
Contributor

@jsbean jsbean commented Jul 13, 2019

This is just a typo fix but it is public API.

MaxDesiatov
MaxDesiatov approved these changes Jul 13, 2019
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a breaking change, good thing we're not 1.0 yet to bump a major version 😄

@MaxDesiatov MaxDesiatov merged commit e17d335 into CoreOffice:master Jul 13, 2019
@jsbean jsbean deleted the bean/length branch July 15, 2019 21:31
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
@jsbean
Fix typo: errorContextLenght -> errorContextLength (CoreOffice#114)
f0d17d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsbean @MaxDesiatov