Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Root Level Attribute Encoding #134

Merged
merged 3 commits into from Oct 4, 2019

Conversation

bwetherfield
Copy link
Collaborator

Resolves #127. I think the plist encoding/decoding should be independent of the XML encoding phase. I have tried to reproduce just the relevant encoding phase and it seems to work.

Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!

@MaxDesiatov MaxDesiatov merged commit b428781 into CoreOffice:master Oct 4, 2019
bwetherfield added a commit to bwetherfield/XMLCoder that referenced this pull request Oct 16, 2019
Resolves CoreOffice#127. I think the plist encoding/decoding should be independent of the XML encoding phase. I have tried to reproduce just the relevant encoding phase and it seems to work.
@MaxDesiatov MaxDesiatov changed the title Root Level Attribute Encoding Test Root Level Attribute Encoding Oct 17, 2019
arjungupta0107 pushed a commit to salido/XMLCoder that referenced this pull request Jun 26, 2020
Resolves CoreOffice#127. I think the plist encoding/decoding should be independent of the XML encoding phase. I have tried to reproduce just the relevant encoding phase and it seems to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root level attributes don't get encoded back to attribute when converting back to XML file from Plist
3 participants